search

navit-gps / website

The sourcecode of the Navit website
http://navit-gps.github.io/website/
1 stars 5 forks source link

OSM trademark message and fix typo #11

Closed aerostitch closed 5 years ago

aerostitch commented 5 years ago

Fixes: https://github.com/navit-gps/navit/issues/849

mvglasow commented 5 years ago

Where would the trademark disclaimer appear? In the animation? Or somewhere else?

aerostitch commented 5 years ago

Yes, it will look like: Screenshot from 2019-09-04 14-24-51 (Based on the way I undferstand the OpenStreetmap trademark policy it has to be the closest possible to the trademark itself)

mvglasow commented 5 years ago

Looks good to me, except that there is still a typo (should be “disclaimer”, not “discalimer”). Although, as I understand the comment by @simonpoole in navit-gps/navit#849:

I would suggest adding disclaimers to the footer

it would be sufficient to place the disclaimer in the footer, not necessarily in the banner itself.

aerostitch commented 5 years ago

Thanks for the review. I fixed the disclaimer typo.

If you read the policy it states:

The notice should appear near the first use of any OSM mark. One notice is enough if you display multiple marks, provided the notice refers to all of them.

Which made me think that the disclaimer should be closer than the footer. @pgrandin @jkoan opinion on this?

jkoan commented 5 years ago

Sory guys, i missed this one