search

navossoc / KeePass-Yet-Another-Favicon-Downloader

Yet Another Favicon Downloader for KeePass 2.x
MIT License
535 stars 31 forks source link

[FIXED] Release as standalone plugin #1

Closed sergeevabc closed 7 years ago

sergeevabc commented 7 years ago

Dear Rafael, Could you be so kind to release your plugin in a proper form for end-users, i.e.*.plgx?

navossoc commented 7 years ago

Sure, I have plans to release it...

I took a break from the project, but I plan to resume it on the next week.

At the moment there is no advantage in using the plugin, since it lacks a crucial part of the implementation (that would be to search for the favicon in html page, I got it hardcoded it as a /favicon.ico file)

I'll let you know about any news. 👍

navossoc commented 7 years ago

@sergeevabc I've pushed some commits today, now the plugin can be considered a bit more usable.

In my internal tests, I have downloaded +6000 favicons in less than 15 minutes (of a 10000 total). It still needs more work to be stable, accurate and fast.

For now, I'll analyze some results in more depth to see if the website really don't have a favicon or I'm missing something. I already found some errors and a few places that needs improvement.

Soon I'll see how to pack a .plgx file and release the first version. I'll let you know again when I have more news.

[]'s

navossoc commented 7 years ago

Hey @sergeevabc and @photonometric Sorry for the wait, but the the time has finally come 👍. Depending on how things go, the next update will be much faster.

You can check the main page of this repository to get more information about the plugin itself and where to get it.

I did some additional tests and It should work on lower requirements, but it may need some fixes. I know there may be a few issues and I still have some ideas to improve the plugin, however I want to check first how it will be accepted.

Please let me know what you guys think about it and any feedback is welcome.

Thanks.

sergeevabc commented 7 years ago

Dear Rafael, is some kind of error report planned (to see how many records and why were failed to get favicon)?

navossoc commented 7 years ago

@sergeevabc Well, you can see how many have succeeded or failed in the status bar, but that definitely is not a detailed report.

For sure, what you suggested can be an improvement. I think I can look at into later. Any suggestions on how this report will be presented back to the user?

Besides that, are you using the plugin? Any problem to install? What environment are you using? Do you have any feedback at all?

PS: If you can, I think it will be a good idea create a new issue to discuss the idea of the detailed report.

sergeevabc commented 7 years ago

you can see how many have succeeded or failed in the status bar

Oh, Rafael, I missed that notice after the first launch. Perhaps status label should be extended to “Favicons report: ...”, and verbosity could be added later.

Besides that, are you using the plugin?

Yes, as a lower footprint alternative to Favicon Downloader with a nice context menu icon. Installation is usual, i.e. put .plgx into /Plugins and restart Keepass, environment is Windows 7 x64.

navossoc commented 7 years ago

Sure, that can be easily done. I need to see how to create a TODO list or something like that here on GitHub.

Anyhow, I think I'll close this issue now, since the plugin is already released.