search

navossoc / KeePass-Yet-Another-Favicon-Downloader

Yet Another Favicon Downloader for KeePass 2.x
MIT License
532 stars 30 forks source link

recursive download #14

Closed bmcdonnell closed 6 years ago

bmcdonnell commented 6 years ago

Feature request: support recursive download, i.e. download Favicons for sites in nested folders.

Stated another way, download icons for entries when "Download Favicons" is selected on a folder containing their parent folders.

navossoc commented 6 years ago

This is easy to do, but I'm not sure how to distinguish both options (one level or nested). Maybe two items on the context menu or one setting on the tools menu? Any suggestion on that?

I think I'm almost three months behind on the "error report" that I promised. I started messing with a mail server and the thing is much harder than I expected, but I still have plans for YAFD.

bmcdonnell commented 6 years ago

Is the one-level option sometimes still preferable/useful if the recursive method were available? If not, you could just change the behavior. If so...

IDK that I have a preference of two options in the context menu vs. a behavior selector in settings/options for the one option in the context menu.

Another option would be settings/options to show one, the other, or both in the context menu. (I think I'm partial to that, actually.)

If a "default behavior" makes sense in the context of whatever UI you choose, IMO recursive should be the default.

navossoc commented 6 years ago

Just to know, did you enable the "Show Entries of Subgroups" in the "View" menu?

It's just another idea, but maybe I can link this behavior on YAFD with that KeePass setting.

bmcdonnell commented 6 years ago

did you enable the "Show Entries of Subgroups" in the "View" menu?

No.

Tiwas commented 6 years ago

This is a great idea. If someone wants it just one level deep they can temporarily move the subfolders they don't want parsed, run the plugin and then move the subfolders back. I think most people would be very happy with just a means to do a recursive sweep.

navossoc commented 6 years ago

Just to know, did you enable the "Show Entries of Subgroups" in the "View" menu?

It's just another idea, but maybe I can link this behavior on YAFD with that KeePass setting.

To be honest I was already doing that...

Anyway, commit https://github.com/navossoc/KeePass-Yet-Another-Favicon-Downloader/commit/4b8d84c1d7134689c6632f868e8c0bedc958e03b changes it.

If someone wants it just one level deep they can temporarily move the subfolders they don't want parsed,

You can also select only the entries you want, right-click on them and download them without having to move groups.