navossoc / KeePass-Yet-Another-Favicon-Downloader

Yet Another Favicon Downloader for KeePass 2.x
MIT License
532 stars 30 forks source link

[Question] What are the differences between this plugin and the "orignal" favicon downloader? #15

Closed soul4soul closed 6 years ago

soul4soul commented 6 years ago

What are the differences between this plugin and the "orignal" favicon downloader?

navossoc commented 6 years ago

I think this may answer your question: https://github.com/navossoc/KeePass-Yet-Another-Favicon-Downloader/issues/4 https://github.com/navossoc/KeePass-Yet-Another-Favicon-Downloader#features

soul4soul commented 6 years ago

I did read it. I guess I'm not too familiar with the original favicon downloader even thought I use it. On second read it seems most of the bullet points under "features" are the differences.

How does the avoid duplicate icons feature work? If I installed it now would it be able to retroactively clean up duplicate icons? What constitutes a duplicate icon? eg.perhaps a binary match

navossoc commented 6 years ago

How does the avoid duplicate icons feature work?

If one or more URLs points to the same favicon file, I can reuse the same icon and avoid store it twice on your password database.

What constitutes a duplicate icon? eg.perhaps a binary match

Yes, it is a binary match.

Keep in mind that it works only for the icons downloaded by YAFD.

If I installed it now would it be able to retroactively clean up duplicate icons?

No, it will not. There are no additional metadata for custom icons, so I can't keep track of where they came from and remove them.

If you want a really clean and tidy database, I suggest you remove all your custom icons and download them all again.


I think I already said this before somewhere else, but to be honest there is no major difference between them, both have the same purpose.

soul4soul commented 6 years ago

👌 Sounds good.