Website compatibility improvements

navossoc / KeePass-Yet-Another-Favicon-Downloader

Yet Another Favicon Downloader for KeePass 2.x

MIT License

532 stars 30 forks source link

Closed lukefor closed 6 years ago

lukefor commented 6 years ago

Fix error downloading from servers that offer modern TLS only (required increasing .NET framework requirement to 4.5)
Support rel="icon shortcut" as seen on a few websites
Use URL after redirection as the base for image requests
Allow more redirections (4 not enough for some sites)
Don't fail completely if first favicon request fails, instead continue to try all remaining links

navossoc commented 6 years ago

Sounds interesting... I'll take a closer look tonight.

Have you tested it?

Thanks.

lukefor commented 6 years ago

Yes works well on my end, got about 20% more favicons working in my database

navossoc commented 6 years ago

Just to keep you in the loop.

I did a few tests, it is working. I'll take a closer look on the linux behavior, do a few changes and them merge it.

So far, so good. 👍

[]'s

navossoc commented 6 years ago

To be honest I didn't merge your pull request. I did a series of smaller commits with some minor changes.

Anyway, thank you very much for the help. I've applied most of your changes.