search

navossoc / KeePass-Yet-Another-Favicon-Downloader

Yet Another Favicon Downloader for KeePass 2.x
MIT License
532 stars 30 forks source link

Error report #2

Open navossoc opened 7 years ago

navossoc commented 7 years ago

As suggested on issue #1 by @sergeevabc

Dear Rafael, is some kind of error report planned (to see how many records and why were failed to get favicon)?

That is a good idea, but, my UX skills are pretty bad 😛 I'm accepting suggestions...

[]'s

user8446 commented 7 years ago

At a minimum how about freezing on the window that has the not found or error? It flashes so fast and then disappears. Thanks for the development!

navossoc commented 7 years ago

As I said on the issue #1:

Well, you can see how many have succeeded or failed in the status bar, but that definitely is not a detailed report.

But it doesn't seems obvious, after all, you are the second one talking about that 😝 (bad UI hahah)

I'm considering creating a special item menu just for debugging. There you can enter the address of the site and get detailed information of the error, as well as which files were found, etc.

I think that will help if you have any doubt about one specific site, but still, need some sort of log to show multiples entries. I'm still thinking about this one, maybe a window with a list of error descriptions should be enough.

user8446 commented 7 years ago

I was right clicking on a individual entry and then download favicons. The status window appears and disappears so fast I can't see the status you are referring to.

navossoc commented 7 years ago

This one:

image

user8446 commented 7 years ago

Got it! Thanks!

photonometric commented 6 years ago

Personally, I think the status window stays open a few seconds too long. Reminds me a bit of the plugin we're replacing. If we could have the same information in the status bar at the bottom, I'm not sure the status window is needed at all, but I think it could be closed instantly and the status bar display left open for...5-10 seconds? Maybe give you a chance to click on it to see what the error was (if that's possible on the status bar with plugins).

At least for me, adding favico has always been a fast process. Yours is much better than the clunky window that had to be confirmed when there was an error, but it still feels like I'm waiting a few seconds to get back into the program....

Just my 2 cents, but I think if it's in the status bar in an unobtrusive way and the window adds nothing but attention-grabbing, it can either be done away with or closed as quickly as possible :)

photonometric commented 6 years ago

I'm considering creating a special item menu just for debugging. There you can enter the address of the site and get detailed information of the error, as well as which files were found, etc.

I think that will help if you have any doubt about one specific site, but still, need some sort of log to show multiples entries. I'm still thinking about this one, maybe a window with a list of error descriptions should be enough.

These are great ideas. For instance, clicking on the status bar info could bring up a pertinent log (maybe of all icons but a selectable tab of errors) and it could tell you the error message.

This seems like it would require lots of programming, and I think should be a little farther down the imaginary roadmap...like below figuring out how to get all the icons possible! ;)

navossoc commented 6 years ago

@photonometric Yeah, for now I'm making the window stay open for 3 seconds. For me too, I feel it is a bit too long, maybe 2 seconds is enough, but this doesn't solve the problem.

I'm not sure if it is possible to handle a click event on the status bar. I need to check this out. If so, it's a good idea, but I'm not sure about how this will behave with another 3rd party plugins doing the same thing.

Presenting the information in the status bar is not bad at all, the only problem with this is: If you invoke the action (download favicon) and click somewhere "by accident" you lost the information on the statusbar (as it will be overwritten by something else). That was the main reason why I made the window stay open for a few seconds.

Anyway, I'll check what else that status bar has to offer, maybe we come up with more good ideas.

xPaw commented 6 years ago

I would like to see a list of sites which threw an error too, currently there is no way of telling which sites failed if you do a batch update.

navossoc commented 6 years ago

To be honest. I'm looking at this. Probably until next week I have something ready.

@xPaw BTW great job on the steamdb and steamstatus 👍

xPaw commented 6 years ago

@xPaw BTW great job on the steamdb and steamstatus 👍

Thanks!

If you want some inspiration for a list, https://github.com/andrew-schofield/keepass2-haveibeenpwned this plugin displays a list of website after scanning, you can probably take a look at how they do it.

navossoc commented 6 years ago

I took a quick look, seems he is using a custom form.

2018-02-17_14-36-20_vmware

I was looking at the KeePass source code and found this dialog (it is used on export/save database)

2018-02-17_14-40-01_keepass

The behavior from that window is a little bit different too. It only shows if there is a warning or an error.

Sure it needs a few changes, like more meaning informational messages and remove all that verbose from the stack, but I think this solves the problem, right?

Probably I will list the entries as entry name: entry url and put the extra information in that big textbox at the bottom.

As we say in Brazil: Playing with UI/UX it's not my beach (it’s not my cup of tea).