search

navossoc / KeePass-Yet-Another-Favicon-Downloader

Yet Another Favicon Downloader for KeePass 2.x
MIT License
532 stars 30 forks source link

Fail to find favicon for opensensemap.org #21

Closed domoenergytics closed 2 years ago

domoenergytics commented 6 years ago

Hi,

YAFD is failing to find the favicon for https://opensensemap.org. I believe it should be finding an icon based on the following tag :

navossoc commented 6 years ago

I'm planning to finish this update this week: (busy days!) https://github.com/navossoc/KeePass-Yet-Another-Favicon-Downloader/pull/19

It may solve the issue. I'll look into.

PS: There is no favicon for me on chrome or edge, just on firefox.

Nikey646 commented 6 years ago

This website appears to use an SVG as an favicon. #19 will not resolve this, and will require additional work (Primarily, converting SVG to an image)

navossoc commented 6 years ago

@Nikey646 TBH, I was thinking about on create/use an external service for grab the favicons. Something like this: http://favicongrabber.com/

Probably it will be easier to maintain, keep updated and even more secure. Since you will not visit the remote website and will get only a reply with the icon data.

Any thoughts?

Nikey646 commented 6 years ago

Just quickly tested the site you linked, and it just returns the .svg itself.

With the fact that a site like that could go down without any warning, it also adds a level of... concern?

navossoc commented 6 years ago

As I said, create or use, so probably I will have a main endpoint offering the service for YAFD and maybe an option to choose another compatible endpoint (if we get there). (or at last resort, try to download it local as it is today)

Also, I think if we have a downtime we can live without downloading a favicon for a few minutes, right?

The best advantage of all will be more compatible with Mono. Since the job on the client side will be much more simpler.

[]'s

navossoc commented 2 years ago

It can be downloaded now using a custom provider. Release v1.2.5.0.