search

navossoc / KeePass-Yet-Another-Favicon-Downloader

Yet Another Favicon Downloader for KeePass 2.x
MIT License
537 stars 31 forks source link

download FavIco failed #37

Closed zen010101 closed 3 years ago

zen010101 commented 4 years ago

https://pixabay.com/

the plugin download this website FavIco failed . Maybe it contains many icons .

JohnLGalt commented 4 years ago

Confirmed. Also, looking at the page source, I found these items:

<link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">

I verified that those are the actual favicons that are loaded by the site into the tab in Firefox.

navossoc commented 4 years ago

That is not the problem, the server is returning a 403 forbidden.

curl -I https://pixabay.com/

https://favicongrabber.com/ also fails.

Not sure why, probably cloudflare challenge against bots.

zen010101 commented 4 years ago

maybe because of the UserAgent

navossoc commented 4 years ago

I have changed the UserAgent here to a newer version of Chrome and it didn't work too...

https://github.com/navossoc/KeePass-Yet-Another-Favicon-Downloader/blob/64b9f54f03d48ebed1b37fe6631ef53dcd9d1ab0/YAFD/FaviconDownloader.cs#L18

They offer a challenge that you will need to solve before enter the site.

[]'s

navossoc commented 3 years ago

It can be downloaded now using a custom provider. Release v1.2.5.0.