navossoc / KeePass-Yet-Another-Favicon-Downloader

Yet Another Favicon Downloader for KeePass 2.x
MIT License
535 stars 29 forks source link

Custom Icons with Names >=KDBX 4.1 KeePass 2.48 #58

Closed 4-FLOSS-Free-Libre-Open-Source-Software closed 2 years ago

4-FLOSS-Free-Libre-Open-Source-Software commented 3 years ago

With KeePass 2.48 a new database format version was introduced, that supports icon names.

It would be nice to have support for this. I could think of using the domain name, the favicon was fetched from, for the icons name. So that you can prevent duplicate redundancy icon storage in db for multiple entry or account of same domains. Or if you start favicon download, to fallback to lookup for existing icons that match Name to the domain part if LastModificationTime is not too old.

JohnLGalt commented 3 years ago

While I do like the naming convention, in my use, if you have multiple accounts on the same domain the icon for the same domain only gets downloaded once. For example, I have several G-Suite accounts, and a few personal Google accounts as well - all the accounts downloaded the icon from 'google.com' but there is only a single entry for the icon in the custom icon database.

Same holds true with multiple Outlook.com accounts, NetZero accounts, and numerous other places where I have multiple accounts on the same domain. I only get 1 copy of the icon and it gets re-used if it is called again.

navossoc commented 3 years ago

@4-FLOSS-Free-Libre-Open-Source-Software I don't think that will be necessary...

Please check https://github.com/navossoc/KeePass-Yet-Another-Favicon-Downloader/issues/35

navossoc commented 2 years ago

Naming icons are coming in the next release :P

navossoc commented 2 years ago

Feature added on release v1.2.5.0.