navossoc / KeePass-Yet-Another-Favicon-Downloader

Yet Another Favicon Downloader for KeePass 2.x
MIT License
532 stars 30 forks source link

Comparison with "Favicon Downloader" #6

Closed Techman closed 6 years ago

Techman commented 6 years ago

What are the major pros/cons of this vs Favicon Downloader?

navossoc commented 6 years ago

Hello @Techman- I tried to summarize some of my changes here: https://github.com/navossoc/KeePass-Yet-Another-Favicon-Downloader#features

Maybe someone can share some feedback with you, but in the end there is no big difference between the plugins, it is just "yet another" plugin. I have no plans for world domination or anything like that. 😆

matthewmcpartland commented 6 years ago

The other Favicon downloader can't handle a URL like http://accounts.google.com. It can handle urls without the http:// part which is nice.

This plugin requires http:// before your URL, explicitly not HTTPS. This plugin should prevent having multiple favicons that are exactly the same. Linux support and light weight I haven't really tested but those are obvious advantages. This plugin has active support from the dev.

navossoc commented 6 years ago

Hey @matthewmcpartland about the prefix, I made an option to change that, you can read more here: https://github.com/navossoc/KeePass-Yet-Another-Favicon-Downloader/wiki/Settings:-Automatic-prefix-URLs-with-HTTP

But it is disable by default, check it out and let me know.

matthewmcpartland commented 6 years ago

With that setting enabled, I really see no reason to use the other plugin. This one is much better for a lot of reasons

Techman commented 6 years ago

I see, thanks.