search

nawforce / apex-assist

VSCode extension for Salesforce Apex development with support for offline validation.
Other
18 stars 2 forks source link

Error on Account person account fields #40

Open nwcm opened 1 year ago

nwcm commented 1 year ago

I can't seem to find a way for apex-assist to correctly work for PersonAccount I have pulled metadata from the org but is still throws image

nawforce commented 1 year ago

Thanks for reporting this, I will take a look if we can workaround this or it needs patching in next few days.

codefriar commented 1 year ago

@nawforce - Love your work with this plugin. I too, am hitting this bug with person account fields. Is there anything I can do to help you expedite a fix?

nawforce commented 1 year ago

Sorry or long delay on this, just work being a bit busy. I have an upstream PR pending that adds the ability to declare standard fields within the metadata we download, prior to this we only support custom fields. Once this is in I can upgrade the download feature to pull the actual org fields if they differ from our pre-packaged versions so we can adapt to org shape.

codefriar commented 1 year ago

@nawforce Anything I can do to help? You mentioned an upstream PR, is it an internal one? I'm happy to test, etc. I'm not a typescript ninja but I know a lil'bit.

nawforce commented 1 year ago

Thanks for the offer, much appreciated. I have been working on finishing up the upstream PR, once that is done I should be able to publish a prerelease version straight away so you can have a play.

nawforce commented 1 year ago

There is a pre-release version available that takes us towards supporting this via allowing new fields to be added to Standard objects or even new Standard objects to be added. I have written up some notes on the pre-release changes over at https://github.com/nawforce/apex-assist/wiki/Prerelease-Changes. Take note of the warning at the end, I would have fixed that but this has been pending for quite a while so thought best make it available as is. This release also has support for goto references in it and other bugfixes.

In the next step I expect to look at updating the download mechanism so it adapts to the org shape, without needing manual work, but would be interested in feedback on if this can cover your use cases once automated.

codefriar commented 1 year ago

@nawforce Thank you for this. I really appreciate it. Can you I bother you for an example of what the directory structure / file would look like to add a field to the platform tier?

nawforce commented 1 year ago

Sure, here is a trivial demo of how things should look, https://github.com/nawforce/apexassist-sobject-sample. Essentially just use sfdx format as you would do normally but remove __c for $platform SObjects. If you load this project in VSCode you should not see any errors. You can verify it's validating by changing the object/field names in the cls file.

I need to do some work on reporting out when we see unexpected files, mostly it just ignores them which has certainly caught me out a few times when I have put things in the wrong place. Once I have deprecated MDAPI format support for better error reporting should become easier.

bhatmand commented 3 months ago

Hi @nawforce, How are you doing? I hope everything is alright. I am facing the same issue and wanted to check if you were able to make any progress on fixing the same. Do we have any plans for the new version release this year? Thank you.

WouterNoordhof commented 2 months ago

Hi! First of all I love this plugin, saves me a lot of time, but unfortunately I also experience the described problem also with the prerelease version. My account object folder does contain the files for the personaccount fields. Would love an update to the plugin! Thanks!