Artisan's Consortium rep not working.

[SiJiL82]

When I gain Artisan's Consortium rep, WonderRep logs out " WonderRep: 0 reputation with Artisan's Consortium - Dragon Isles Branch needed for Revered. (1 reputation gains left) A total of 835 reputation gained this session. estimated time to Revered. "

[nawglan]

sorry this went unanswered for so long. I can only think that it could be because that rep was minimized / collapsed in the reputation window. There isn't anything in the code that would prevent it from working other than being impacted by what is collapsed in the rep window.

[nawglan]

closing request.

[SiJiL82]

The same thing happens with the new Azerothian Archives rep. It's not minimised in the reputation window:

[nawglan]

Thanks, reopened the ticket. I have been playing classic lately, will start a character on retail to see if I can reproduce.

[nawglan]

What are the different ranks that are possible? It could be that I'm just missing those. found it. 1 | Neutral | 0 | 500 2 | Preferred | 500 | 2000 3 | Respected | 2500 | 3000 4 | Valued | 5500 | 7000 5 | Esteemed | 12500

[nawglan]

hopefully adding those will fix the issue.

[SiJiL82]

Unfortunately not

If what you posted before is what needs adding, it might be because they seem to have given all these reps different names for each level...

Azerothian Archives has Soridormi has Glimmerogg Racer has

So you probably have fixed it for Artisan's Consortium (I can't test it any more, I'm at max rep!) but looks like it might need individual updates for every other faction that uses this format?

[SiJiL82]

Just added this to enUS.lua

-- Glimmerogg Racer
L["Aspirational"] = true        --    0 -  700
L["Amateur"] = true             --  700 - 1400
L["Competent"] = true           -- 1400 - 2100
L["Skilled"] = true             -- 2100 - 2800
L["Professional"] = true        -- 2800+

and tested by doing a daily: So looks like each individual rep with different names needs adding :(

I'll create a fork and go through all the ones they've added that are like this over the weekend and send over a PR for you.

[nawglan]

awesome. thanks for helping debug. 8) I'll work on adding all of those.

[nawglan]

there is more to do than just adding the strings to the localization files. and looking at this spaghetti code, it really needs refactored. 8/

Thanks for offering to do a PR.

[nawglan]

how's v2.2.4 working out for yall?

[SiJiL82]

how's v2.2.4 working out for yall?

Just tested with Azerothian Archives and Glimmerogg Racer reps, both working perfectly

Thanks very much!

[nawglan]

Glad to hear it! Closing this. /fingers-crossed 8)