Closed NachoVazquez closed 10 months ago
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
[x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] Other... Please describe:
next-on-pages doesn't export the "bin/index.js' script on the package.json, which causes the @naxodev/nx-cloudflare:next-build* executor to fail.
next-on-pages
Fixes: #30
We execute the next-on-pages package with 'nox' in CLI mode as it was designed to be used.
[ ] Yes [x] No
⚡️ @cloudflare/next-on-pages CLI v.1.7.3 ⚡️ Detected Package Manager: pnpm (8.7.1) ⚡️ Preparing project... ⚡️ Project is ready ⚡️ Building project... ▲ Progress: resolved 1, reused 0, downloaded 0, added 0 ▲ .../Library/pnpm/store/v3/tmp/dlx-82210 | WARN deprecated debug@4.1.1 ▲ .../Library/pnpm/store/v3/tmp/dlx-82210 | WARN deprecated uuid@3.3.2 ▲ .../Library/pnpm/store/v3/tmp/dlx-82210 | WARN deprecated fsevents@2.1.3 ▲ Packages: +247 ▲ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ▲ Progress: resolved 266, reused 247, downloaded 0, added 121 ▲ Progress: resolved 266, reused 247, downloaded 0, added 247, done ▲ Vercel CLI 32.5.5 ▲ Detected `pnpm-lock.yaml` version 6 generated by pnpm 8 ▲ Your application is being built using `next build`. If you need to define a different build step, please create a `vercel-build` script in your `package.json` (e.g. `{ "scripts": { "vercel-build": "npm run prepare && next build" } }`). ▲ Installing dependencies... ▲ Already up to date ▲ ▲ Done in 257ms ▲ Detected Next.js version: 14.0.3 ▲ Running "pnpm run vercel-build" ▲ > @ vercel-build /Users/nachovazquez/work/1-projects/naxodev/oss/tmp/nx-e2e/proj/apps/workerapp6167759 ▲ > next build ▲ sh: next: command not found ▲ ELIFECYCLE Command failed. ▲ WARN Local package.json exists, but node_modules missing, did you mean to install? ▲ Error: Command "pnpm run vercel-build" exited with 1
We also tried executing the command based on the package manager used, but it did the same for pnpx.
pnpx
npx is globally available and works, so we chose it.
npx
34344c9
View logs
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
next-on-pages
doesn't export the "bin/index.js' script on the package.json, which causes the @naxodev/nx-cloudflare:next-build* executor to fail.Fixes: #30
What is the new behavior?
We execute the
next-on-pages
package with 'nox' in CLI mode as it was designed to be used.Does this PR introduce a breaking change?
Other information
We also tried executing the command based on the package manager used, but it did the same for
pnpx
.npx
is globally available and works, so we chose it.