search

nayanaamahesh / pe

0 stars 0 forks source link

Tag issues when deleting goods #15

Open nayanaamahesh opened 2 weeks ago

nayanaamahesh commented 2 weeks ago

Deleting the order of a person also deletes the tag from that person. Even though the person is still a consumables supplier (Just no more orders from that person).

(irfan originally had a consumables tag) image.png

nus-se-bot commented 2 weeks ago

Team's Response

This is the expected behaviour.

The tag information from the goods categories of a supplier goods is added visually (dynamically). The tag information of the supplier remains as it is. (Line 213 of UG)

However, I suppose that this behaviour can be more clearly stated in the documentation.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that this is how the system works as of now (ie expected behaviour) However, I am pointing out the possible logical issues that may arise due to this expected behaviour. Ie the expected behaviour is a bug itself.

## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** I think this is still a functionality bug because of this feature there is limited functionality of this feature. Automatically adding the tag to a person is a good thing However, automatically removing it may cause inconvenience for the user because after the order is over the person will be untagged. Then if the user were to filter to find Consumables suppliers the supplier wouldn't show up even though he is a consumables supplier. User may think they don't need to tag the person because the system automatically does it for them. In order to fix this issue, the user would have to tag the supplier with their own consumables tag which is confusing and does not help the user.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I think it is still severity medium because this is a normal functionality in the app. As soon as the orders are finished, the relevant tag will be removed from the supplier. Then if the user wants to search his address book for possible suppliers of that tag, this supplier would not even show up which would reduce the main functionality of this app. This is not a rare scenario and will happen to every supplier whose orders are finished. This would cause inconvenience to the user.