search

nayash / stock_cnn_blog_pub

This project is a loose implementation of paper "Algorithmic Financial Trading with Deep Convolutional Neural Networks: Time Series to Image Conversion Approach"
Apache License 2.0
165 stars 95 forks source link

"wr" and "money_flow_index" function not defined #7

Closed mikkkeldp closed 3 years ago

mikkkeldp commented 3 years ago

Hi!

I am unable to use the utils.py file since the "wr" (line 258) and "money_flow_index" (line 271) functions are not defined anywhere.

catalinmut commented 3 years ago

Hi!

I am unable to use the utils.py file since the "wr" (line 258) and "money_flow_index" (line 271) functions are not defined anywhere.

Hello mikkkeldp

How did you solve this problem?

regards

yanghoonkim commented 3 years ago

@mikkkeldp @catalinmut the name of functions are changed (ta 0.7.0)

Changes: wr -> williams_r argument 'i' in many functions are changed to 'window'

mikkkeldp commented 3 years ago

Hi catalinmut,

He is using an outdated version of the ta package. To see the new function names: https://technical-analysis-library-in-python.readthedocs.io/en/latest/ta.html .

Regards, Mikkel

On Wed, Feb 10, 2021 at 2:12 PM Yanghoon Kim notifications@github.com wrote:

@mikkkeldp https://github.com/mikkkeldp @catalinmut https://github.com/catalinmut the name of functions are changed (ta 0.7.0)

Changes: wr -> williams_r argument 'i' in many functions are changed to 'window'

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nayash/stock_cnn_blog_pub/issues/7#issuecomment-776665469, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ5QIEDMGDEZ7MWGY74RZ63S6JZ2ZANCNFSM4WNL4EGA .