search

nayaverdier / dyntastic

A DynamoDB library on top of Pydantic and boto3.
MIT License
55 stars 12 forks source link

Transaction configurable commit limit #11

Closed photonbit closed 11 months ago

photonbit commented 11 months ago

As the 100 transaction it is a dynamodb, I decided to keep it as a hard limit and allowed the context manager to be able to accept smaller batches to commit.

photonbit commented 11 months ago

Applied black, the errors in pytest are from areas that I didn't touch in this PR, probably some unpinned library was updated?

nayaverdier commented 11 months ago

@photonbit Thanks for the PR, this looks great! Looks like moto is the culprit: https://github.com/getmoto/moto/issues/6841

Let's pin that to 4.2.2 for now.

I need to add contribution instructions to this repo, but once you create + activate a venv, you can run:

isort is also a failing check

photonbit commented 11 months ago

Done, all green now :heavy_check_mark:

codecov-commenter commented 11 months ago

Codecov Report

Merging #11 (11a815d) into main (4b90aaa) will not change coverage. The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##              main       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          637       641    +4     
  Branches       119       119           
=========================================
+ Hits           637       641    +4
Files Changed Coverage Δ
dyntastic/transact.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more