nayuki
commented
4 years ago Problems with your code:
-
You changed my last line
x, y = y, x + yfor no good reason. -
The 3 lines you added have no whitespace, in violation of my formatting standards.
-
You didn't delete my existing code. This means the new overall code will compute the solution twice and print it twice, which is very wrong.
-
You failed to notice that eulertest.py loads every solution (pXXX.py) and calls its
main()function, then checks the answer against the known-good answer. This is whymain()must be kept. -
When things are written my way,
main()can be declared above subfunctions and still work:def main(): ans = foo() print(ans) def foo(): bar() def bar(): pass
When things are written your way, all subfunctions and global variables/constants must be declared above
main():def foo(): bar() def bar(): pass ans = foo() print(ans)
-
Why are you even proposing this change? It is not an improvement on my work. It is a disimprovement.
xiaowuc2
jeremydouglass
without using function