search

nayuki / QR-Code-generator

High-quality QR Code generator library in Java, TypeScript/JavaScript, Python, Rust, C++, C.
https://www.nayuki.io/page/qr-code-generator-library
5.2k stars 1.11k forks source link

Add basic scheme implementation #189

Closed jobol closed 1 year ago

jobol commented 1 year ago

hi, I'm pushing a new language implementation. Feel free to accept it or not. Best regards Jo

jobol commented 1 year ago

Post scriptum: I tested it and it worked for me

nayuki commented 1 year ago

I acknowledge your effort in making this unsolicited language port. Unfortunately, I cannot accept your submission as I don't have the necessary skills to write and audit code in Scheme. I personally stand behind all the code in this repository, and want to continue being able to make changes to all language ports simultaneously when needed.

As well, please don't submit unwarranted changes to my Python codebase.

As this is an open-source project, you are more than welcome to host your Scheme language port yourself and answer to anyone using your codebase. As well, I can add you to this list: https://www.nayuki.io/page/qr-code-generator-library#third-party-ports

jobol commented 1 year ago

Sorry for the changes in python, that was unexpected.

I understand your point. I'm going to setup a public repository for adding it in third parties list. I'll let you know when it is done (in the coming days) by closing that PR.

Thanks

jobol commented 1 year ago

I made the repo. You can browse it here. Can you check if the authoring and copyright is okay for you? I removed your authorship because even if most comments are yours, I think that you just want to be far from that code. But in the readme I made a clear explanation of your work and the role you played. Let me know if you agree or if you have any suggestion of improvement.

https://gitlab.com/jobol/qrcode-gen

jobol commented 1 year ago

no word means agreement

nayuki commented 1 year ago

My project is an unpaid work that I contribute to on a volunteer basis. It sounds like you expect a fast response time, which is not guaranteed in this context.

I took a look at your published codebase and it's alright as it stands. Strictly speaking, because you cloned the structure and naming of my code, you have created a derivative work, which means you cannot remove my copyright text and replace it with your own. However, I'll let this slide in the interest of simplicity as you have mentioned me in the readme. I went ahead and added a link to your work in https://www.nayuki.io/page/qr-code-generator-library#third-party-ports . Thanks for your patience.

jobol commented 1 year ago

Thank you Nayuki