search

nayutaco / ptarmigan

Lightning Network (BOLT)
Apache License 2.0
132 stars 19 forks source link

Correct name of upcode 0x4e to OP_PUSHDATA4 #1654

Closed mathiasrw closed 4 years ago

mathiasrw commented 4 years ago

OP_PUSHDATA3 is not part of bitcoin script. Only OP_PUSHDATA1, OP_PUSHDATA2 and OP_PUSHDATA4 are valid.

https://github.com/bitcoin/bitcoin/blob/master/src/script/script.h#L59-L61

This change is Reviewable

nayuta-ueno commented 4 years ago

Thank you for your request! Some corrections please.

https://github.com/nayutaco/ptarmigan/blob/69b26470310daa24f95cb83eefde8e539eff6d96/btc/btc_script.c#L874

https://github.com/nayutaco/ptarmigan/blob/69b26470310daa24f95cb83eefde8e539eff6d96/btc/btc_script.c#L886

nayuta-ueno commented 4 years ago

Thank you!

https://github.com/nayutaco/ptarmigan/pull/1654#issuecomment-631859061

There is one more correction left to fix. Please fix L.874 in script.c.

https://github.com/nayutaco/ptarmigan/blob/69b26470310daa24f95cb83eefde8e539eff6d96/btc/btc_script.c#L874

mathiasrw commented 4 years ago

Woops. Sorry. Fixed now!

mathiasrw commented 4 years ago

:tada: