Fixed replacement of basePath at the beginnings of URLs

naz / swagger-express-validator

Lightweight requrest/response validation middleware based on swagger/OpenAPI schema

MIT License

56 stars 24 forks source link

Fixed replacement of basePath at the beginnings of URLs #59

Closed kantord closed 3 years ago

naz commented 3 years ago

Hey @kantord . Can you please expand on what usecase you are trying to solve with this change? Cheers!

kantord commented 3 years ago

Hi @naz, thanks for the quick reply.

It's 2 things:

Fixes a bug with base paths. Before the fix, based paths were removed even from the middle of URLs, for example if the base path is '/foo/' then '/api/bar/foo/baz/' was normalized to '/api/bar/baz' which is a bug
It adds support for servers https://swagger.io/docs/specification/api-host-and-base-path/

kantord commented 3 years ago

I realized this is probably a mistake on my part. I realized this package is only meant to support OpenAPI v2.0, so probably servers support is not revelant here. If you want, I can remove the servers support part and only push the bugfix

naz commented 3 years ago

Yeah, just the bugfix would be ideal. Thanks @kantord

kantord commented 3 years ago

Cool, now it's just the bugfix, @naz :wink: