search

nazar-pc / CleverStyle-Music

CleverStyle Music Open Web App. Music player for Firefox OS built using open web technologies.
https://marketplace.firefox.com/app/cleverstyle-music/
MIT License
18 stars 3 forks source link

Cover.jpg not supported as cover album #4

Closed inkhey closed 9 years ago

inkhey commented 10 years ago

Same problem as : https://bugzilla.mozilla.org/show_bug.cgi?id=1060331

Steps to reproduce:

1.Create a music album folder on computer with music files (with no cover album tag) and cover.jpg file as album cover. 2.Transfer this folder to Flame device . 3.Open CleverStyle-Music application on Flame device.

Actual results:

There is no detected album cover .

Expected results:

I should have a cover album (cover.jpg) for music files that are in the same folder as cover.jpg.

This "trick" work fine on my walkman and on computer program like Rhythmbox on linux.

nazar-pc commented 10 years ago

Yes, you are right, only embedded covers are supported right now. I can't promise to fix it very soon, but I'll try to fix this. There are still many limitations in Firefox OS which I can't fix in app, for instance CleverStyle Music gets music files from music storage, and knows nothing about directories where files are located, and none of image files are listed as the result (so I'm unable to fix this issue right now), but when I tried to start using sdcard storage it doesn't work as expected (you can vote for this bug). Another issue was reported as #3.

So, I definitely want to fix this, but it is impossible right now (though, I'm planning to load covers from some external services in future releases, so, files with correct meta information but without covers will get them automatically).

Finally, project is Open Source and will always be, so, you can fork it, try to fix issue, and send pull request, I'll be happy to accept it.

nazar-pc commented 10 years ago

Good news, bug with sdcard is Simulator-specific, moreover, there is a workaround to fix this. So, as soon as I'll find enough time - this feature will be implemented.

nazar-pc commented 9 years ago

@inkhey, it was a long way, but I have some time last days. Now player works with sdcard storage instead of music, which means that we now have access to files of any type. Covers should be in Git version in few days.

nazar-pc commented 9 years ago

Implemented with 84eea06, please, check it