search

nazar-pc / PickMeUp

Really simple, powerful, customizable and lightweight standalone datepicker
BSD Zero Clause License
616 stars 191 forks source link

invalid check "date instanceof Number" #213

Closed evdevel closed 5 years ago

evdevel commented 5 years ago

https://github.com/nazar-pc/PickMeUp/blob/f886f03eaad532f5ba5ff6b7706eff5fd341bf40/js/pickmeup.js#L550

I think that the check is not working correctly. For example, if I pass time in milliseconds in the max parameter, then the check will not work. Probably worth checking out in the following way. typeof date === 'number'

nazar-pc commented 5 years ago

I think you are right, PR is definitely welcomed

nazar-pc commented 5 years ago

Fixed in 3.2.1