search

nazar-pc / PickMeUp

Really simple, powerful, customizable and lightweight standalone datepicker
BSD Zero Clause License
616 stars 191 forks source link

updated panel to BS4 #226

Open gbjbaanb opened 4 years ago

gbjbaanb commented 4 years ago

fixed #225 - changed to use bootstrap 4's card rather than the old panel class

nazar-pc commented 4 years ago

Why was z-index added in contrast to comment that is there explaining how it should be updated?

gbjbaanb commented 4 years ago

because the issue I raised mentioned it too. There are 2 commits, github seems to have associated them both with the same issue, I ahave no problem with that, fixes the original comment.

nazar-pc commented 4 years ago

Let's make setting that style with JS instead, otherwise with styles update you'll not be able to replicate the same CSS using provided instructions, it is really no for manual editing.

Also can't we use both classes to make it compatible with both bootstrap 3 and 4? I wouldn't want to bump major version of the library just because of this change.

gbjbaanb commented 4 years ago

Bootstrap 3 is EOL (3.3.7 release Jul 2016), and Bootstrap 5 will be available soon. So I guess it depends how many versions you want to support now. Personally, I'd put a bit of documentation in to say how to downgrade it for bootstrap3 if needed.