search

nazar-pc / docker-phpmyadmin

phpMyAdmin as Docker container, based on official image, always latest version
40 stars 16 forks source link

Make image ready for OpenShift container platform #22

Closed bittner closed 6 years ago

bittner commented 6 years ago

These changes make the image ready for the OpenShift container platform, which runs containers with an unprivileged user (to avoid privileged access to the host machine).

New environment variables:

Closes #21.

nazar-pc commented 6 years ago

Released under tag 4.8.3+build-2

bittner commented 6 years ago

Trying out the new image I see that there are now issues running sed in the entrypoint.

$ docker run --rm -u 1001 -p 8080 -p 4443 -e HTTP_PORT=8080 -e HTTPS_PORT=4443 nazarpc/phpmyadmin
sed: couldn't open temporary file /etc/apache2/sedtkrRe9: Permission denied

I'm investigating how to get this fixed.

(In our solution sed was run in the Dockerfile, hence by root.)

nazar-pc commented 6 years ago

Fixed in latest commit, removed 4.8.3+build-2 image from Docker Hub

bittner commented 6 years ago

I'll test your changes - anyway -, but I fear chgrp and chmod should also run over /etc/apache2 (see comment).

bittner commented 6 years ago

Yes, same result. Should I make the proposed changes?

I'd also correct the usage example in the README (port specification, and omit mysql for brevity), i.e.

docker run --rm --user 1001 -p 8080:8080 -p 4443:4443 -e HTTP_PORT=8080 -e HTTPS_PORT=4443 nazarpc/phpmyadmin