nazar-pc / docker-phpmyadmin

phpMyAdmin as Docker container, based on official image, always latest version
40 stars 16 forks source link

Allow no password #3

Closed francisbesset closed 9 years ago

nazar-pc commented 9 years ago

Why do you need this? Official containers require password to be set anyway, so it doesn't make sense, just potential security hole.

francisbesset commented 9 years ago

It is simple to setup a project in dev environment without password. The official mysql image allow no password with MYSQL_ALLOW_EMPTY_PASSWORD environment variable.

It is a security hole only if the mysql server allow no password!

nazar-pc commented 9 years ago

Well, it makes sense. But can you align all assignments and leave empty line as it was originally? I do not like when someone reformats my code, please, respect it) I'll merge PR right after that.

francisbesset commented 9 years ago

No problem, it's done!

Thank you very much.

nazar-pc commented 9 years ago

It is not really aligned, but I'll fix that myself. Thanks for contribution!