search

nazrhyn / gitlab-slack

A service that receives hook notifications from GitLab and posts information to an incoming webhook on Slack.
MIT License
79 stars 20 forks source link

Support for pipeline events #27

Open yegorski opened 6 years ago

yegorski commented 6 years ago

Do you plan to listen for "Pipeline events"?

One thing I can see being useful is custom notifications on important events, such as master build failing, etc, where the Slack integration would do an @here to the channel.

nazrhyn commented 6 years ago

Actually, we're about to dig into GitLab CI soon, at work. I will definitely need to make some modifications for that, and will also fix some more of these pending bugs and vulnerable packages.

nazrhyn commented 5 years ago

I was able to reorganize my 10% time at work :tada:, which will give me more time to work on this, periodically. I just released 2.1.0 which resolved 5 of the pending issues and brings the package dependencies and the code up to date.

Pipeline events are next!

nazrhyn commented 5 years ago

@genru I noticed that you have a fork with some work done for the pipeline and build events. When I go to implement those here, may I use your code either directly or as a reference?

genru commented 5 years ago

@nazrhyn sure, please. but have no any guarantee

genru commented 5 years ago

need i make a pull request?

nazrhyn commented 5 years ago

@genru Whatever you prefer. I am happy to simply use it as reference, especially if you think there may be improvements to be made.

genru commented 5 years ago

@nazrhyn https://github.com/nazrhyn/gitlab-slack/pull/29

nazrhyn commented 5 years ago

@genru @yegorski I'm starting this and was interested to hear your thoughts about something:

When would you want to see notifications for individual jobs/builds within a pipeline? Wouldn't that be pretty spammy?

If a pipeline fails, then the builds list can be looked at to determine which job/build has failed, and then that can be sent to Slack, but actually showing every single job/build seems like overkill.

genru commented 5 years ago

@nazrhyn Yes, pipeline hooks everything. it is a bit too many events. I thought only notify key pipeline events would be nice.

I dont understand what do you mean "the builds list can be looked at to determine which job/build has failed". I use .gitlab-ci.yaml do my CI work, In my scenario, when a job failed just has one message pipeline xxxx by xxx failed comes in.

nazrhyn commented 5 years ago

Your first response is kind of what I was looking for. We'll see how it goes!