nazrulworld / fhir.resources

FHIR Resources https://www.hl7.org/fhir/resourcelist.html
https://pypi.org/project/fhir.resources/
Other
365 stars 104 forks source link

R4B #114

Closed bwalsh closed 1 year ago

bwalsh commented 1 year ago

This PR addresses #110:

Currently, testing shows these validation errors:

fhir/resources/tests/test_activitydefinition.py - timingTiming null not allowed
fhir/resources/tests/test_implementationguide.py - url missing scheme
fhir/resources/tests/test_library.py -  url missing scheme
fhir/resources/tests/test_plandefinition.py - timingTiming null not allowed, url missing scheme
fhir/resources/tests/test_relatedperson.py -  url missing scheme

fhir/resources/tests/test_searchparameter.py - __root__ -> base field required, id ensure this value has at most 64 characters
tests/test_utils_xml.py -  Value is expected from the instance of <class 'fhir.resources.fhirprimitiveextension.FHIRPrimitiveExtension'>, but got type <class 'fhir.resources.R4.fhirprimitiveextension.FHIRPrimitiveExtension'> (type=value_error)

TODO: As far as I can tell, these errors are expected - given the example data. I wonder if the example data needs to be tweaked in order to generate passing tests?

Please let me know if this is the right approach, feedback ,etc.
Motivated to get a R4B compatible and eventually 5.0 releases created.

bwalsh commented 1 year ago

TODO: As far as I can tell, these errors are expected - given the example data. I wonder if the example data needs to be tweaked in order to generate passing tests?

nazrulworld commented 1 year ago

Hi @bwalsh thanks a lot for your PR.

  1. It is very important that all tests should pass through travis.
  2. I think we will not create a separate folder (sub-package) for R4, there is no major difference between R4 and R4B as far as I understand.
nazrulworld commented 1 year ago

https://github.com/nazrulworld/fhir.resources/commit/98b19ecbaa3778fd5ece74990bdc77fd5d1afc70

bwalsh commented 1 year ago

@nazrulworld Hey! You beat me to it. Thanks very much.

bwalsh commented 1 year ago

@nazrulworld thanks again, are you going to release it on pypi?

nazrulworld commented 1 year ago

I hope that within the new year.