search

nazrulworld / fhir.resources

FHIR Resources https://www.hl7.org/fhir/resourcelist.html
https://pypi.org/project/fhir.resources/
Other
372 stars 104 forks source link

Dec2020iac #43

Closed iatechicken closed 3 years ago

iatechicken commented 3 years ago

DSTU2 resources: supplydelivery.py substance.py subscription.py

nazrulworld commented 3 years ago

Thanks a lot, I will do the merge soon, but do you have more resources to push?

iatechicken commented 3 years ago

There's like 13~ ish resources left based on the issue board. I'm planning on doing like 2 or 3 a day, which probably gets us to end of this week. Do you need it faster?

nazrulworld commented 3 years ago

There's like 13~ ish resources left based on the issue board. I'm planning on doing like 2 or 3 a day, which probably gets us to end of this week. Do you need it faster?

It's fully fine, take your time, please 💯

nazrulworld commented 3 years ago

https://github.com/nazrulworld/fhir.resources/blob/5.X.X/fhir/resources/DSTU2/questionnaire.py there you will find example of nested group also https://github.com/nazrulworld/fhir.resources/blob/master/fhir/resources/STU3/questionnaire.py

iatechicken commented 3 years ago

https://github.com/nazrulworld/fhir.resources/blob/5.X.X/fhir/resources/DSTU2/questionnaire.py there you will find example of nested group also https://github.com/nazrulworld/fhir.resources/blob/master/fhir/resources/STU3/questionnaire.py

hmm ok, so just copy paste mostly with different title/description, and watch for whether it's a ListType or not. thanks!

One more low hanging question. For the remaining resources, do you want me to cut a new branch and create a new pull request? or should I keep committing on to this pull request?

nazrulworld commented 3 years ago

https://github.com/nazrulworld/fhir.resources/blob/5.X.X/fhir/resources/DSTU2/questionnaire.py there you will find example of nested group also https://github.com/nazrulworld/fhir.resources/blob/master/fhir/resources/STU3/questionnaire.py

hmm ok, so just copy paste mostly with different title/description, and watch for whether it's a ListType or not. thanks!

One more low hanging question. For the remaining resources, do you want me to cut a new branch and create a new pull request? or should I keep committing on to this pull request?

keep committing 👍

iatechicken commented 3 years ago

supplydelivery.py substance.py subscription.py searchparameter.py riskassessment.py referralrequest.py questionnaire.py questionnaireresponse.py provenance.py processresponse.py processrequest.py parameters.py paymentreconciliation.py paymentnotice.py operationdefinition.py nutritionorder.py testscript.py

done

nazrulworld commented 3 years ago

Great thanks, 🙏 I will review it soon. Hope we will have the final release before Christmas vacation.

nazrulworld commented 3 years ago

LGTM! Thanks a lot,