search

nbQA-dev / nbQA

Run ruff, isort, pyupgrade, mypy, pylint, flake8, and more on Jupyter Notebooks
https://nbqa.readthedocs.io/en/latest/index.html
MIT License
1.01k stars 39 forks source link

`tests/tools/test_ruff_works.py::test_ruff_works` fails with latest ruff 0.1.2 #834

Closed GaetanLepage closed 9 months ago

GaetanLepage commented 10 months ago

Yesterday ruff 0.1.2 was released. With this new version, the following test fails:

E       AssertionError: assert 'Found 13 err...ed but unused' == 'Found 13 err...ed but unused'
E           Found 13 errors.
E         - [*] 10 potentially fixable with the --fix option.
E         ?       ------------
E         + [*] 10 fixable with the `--fix` option.
E         ?                         +     +
E           tests/data/notebook_for_testing.ipynb:cell_1:1:8: F401 [*] `os` imported but unused
E           tests/data/notebook_for_testing.ipynb:cell_1:3:8: F401 [*] `glob` imported but unused...
E
E         ...Full output truncated (11 lines hidden), use '-vv' to show

tests/tools/test_ruff_works.py:72: AssertionError
MarcoGorelli commented 9 months ago

fixed, thanks

GaetanLepage commented 9 months ago

Indeed ! thanks :)