search

nbQA-dev / nbQA

Run ruff, isort, pyupgrade, mypy, pylint, flake8, and more on Jupyter Notebooks
https://nbqa.readthedocs.io/en/latest/index.html
MIT License
1.01k stars 39 forks source link

tests/tools/test_ruff_works.py fails as ruff <path> was deprecated in ruff 0.3.0 #837

Closed funkeleinhorn closed 5 months ago

funkeleinhorn commented 6 months ago

ruff 0.3.0 deprecated ruff <path> in favor of ruff check <path>. See this PR for more info. Because tests/tools/test_ruff_works.py uses ruff <path> the test now fails. The test should be updated to use ruff check <path>.

MarcoGorelli commented 6 months ago

thanks - want to make a pr?

funkeleinhorn commented 6 months ago

I just stumbled across this while updating the ruff Nix Package. I quickly replaced ruff with ruff check in test_ruff_works.py but the tests test_ruff_isort and test_pylint_works still fail. Sadly I dont have the time to dive in the codebase of another project so I will probably not be able to make a pull request here in the near future. So probably it will be better/faster if someone how is using/already contributed here picks this up.

funkeleinhorn commented 6 months ago

Found the time to look into it and created a PR.