search

nbQA-dev / nbQA

Run ruff, isort, pyupgrade, mypy, pylint, flake8, and more on Jupyter Notebooks
https://nbqa.readthedocs.io/en/latest/index.html
MIT License
1.01k stars 39 forks source link

fix ruff tests by running the quiet mode #847

Closed GaetanLepage closed 5 months ago

GaetanLepage commented 5 months ago

The latest version of ruff (0.3.3) does not have an empty stdout when succesfull. This can be restored by passing the --quiet flag.

MarcoGorelli commented 5 months ago

@all-contributors please add @GaetanLepage for tests

allcontributors[bot] commented 5 months ago

@MarcoGorelli

I've put up a pull request to add @GaetanLepage! :tada:

GaetanLepage commented 5 months ago

Thanks for merging ! Is a new release planned soon ?

MarcoGorelli commented 5 months ago

do you need a release, given that it only affects tests?

GaetanLepage commented 5 months ago

This would let us update ruff on nixpkgs: https://github.com/NixOS/nixpkgs/pull/296256 We can still cherry-pick this patch. I fully understand that this might not be worth a release for you.

MarcoGorelli commented 5 months ago

no worries, just made a new one

GaetanLepage commented 5 months ago

Thanks !