Levels fail to load with the color restoration mod of Super Mario Advance 4

nba-emu / NanoBoyAdvance

A cycle-accurate Nintendo Game Boy Advance emulator.

GNU General Public License v3.0

974 stars 56 forks source link

Levels fail to load with the color restoration mod of Super Mario Advance 4 #282

Closed Adamillo closed 1 year ago

Adamillo commented 1 year ago

The levels load fine in open AGB firm on the 3DS so technically the game should run fine on real GBA hardware as well. Link to the ROM hack: https://www.romhacking.net/hacks/3315/ This was tested with the latest Nightly build

fleroviux commented 1 year ago

It appears that this hack does not like my Serial IO IRQ stub. When I remove the stub, the levels successfully load. This shouldn't be too difficult to fix - just needs some extra checks when the IRQ really should be asserted I think.

fleroviux commented 1 year ago

@Adamillo Sorry, I forgot to mention this until now, but this issue should be fixed in the 1.7 release from a few days ago.

Adamillo commented 1 year ago

Awesome!