nba-emu / NanoBoyAdvance

A cycle-accurate Nintendo Game Boy Advance emulator.
GNU General Public License v3.0
955 stars 53 forks source link

Sky effect in Harmony of Dissonance is slightly broken. #284

Closed Michpem closed 1 year ago

Michpem commented 1 year ago

Hi there! I was playing through Castlevania Harmony of Dissonance and I found a (harmless) graphical bug with the sky effect in the Chapel of Dissonance. It seems like the background doesn't loop well in the emulator, which causes the clouds to not seamlessly connect in some areas and to have weird black bars.

Here's a (poorly recorded lol) .gif of how it looks:

https://cdn.discordapp.com/attachments/597986077197729803/1083140837216616579/Sky_Effect.gif

Also, it's a bit hard to fully see it because of the nature of the video (I grabbed the first one I found), but here's how the effect is supposed to look:

https://youtu.be/siIAivGSySs?t=7950

I know almost nothing about the GBA, but it may be a mode 7 issue? Also, if necessary, I'm on NBA 1.6.

fleroviux commented 1 year ago

Can you attach a save file (or if that's not possible a save state) please? I don't want to play through the game just so I can reproduce the issue. Thanks!

Michpem commented 1 year ago

Yeah for sure. Here it is:

https://cdn.discordapp.com/attachments/597986077197729803/1083147760901038132/Castlevania_-_Harmony_of_Dissonance.sav

I was playing a randomizer, but I can confirm the save works with the vanilla ROM and that the graphical bug is also present there.

fleroviux commented 1 year ago

I can reproduce the problem in 1.6, but it looks to be gone in the latest development build. I probably unknowingly fixed it during a recent big rewrite of the video emulation code. Can you confirm that the problem is fixed in that version?

Michpem commented 1 year ago

Yep, it works just fine in the development build.

fleroviux commented 1 year ago

Alright! Thanks for confirming, I'll close the issue then.