nba-emu / NanoBoyAdvance

A cycle-accurate Nintendo Game Boy Advance emulator.
GNU General Public License v3.0
955 stars 53 forks source link

CI builds could be better labeled #311

Open RetroEdit opened 1 year ago

RetroEdit commented 1 year ago

Ideally, development builds would have the commit hash in filename of the artifact and also in the Help > About NanoBoyAdvance menu. The About page could also have the NBA version for that matter, though I guess that's in the window title. As far as I'm aware, there's nothing in the downloaded files that directly indicates the version's hash or equivalent identifier.

I guess there's an alternative download that gives the build ID, but that's still a bit indirect.

fleroviux commented 1 year ago

Yeah, the way this is handled currently definitely isn't ideal. The emulator version is also hardcoded in a couple of places currently.

fleroviux commented 11 months ago

image

In development builds the window title now includes the branch name and commit hash.

RetroEdit commented 11 months ago

Including the version + branch name + hash in Help > About NanoBoyAdvance would also be useful for copy-pasting, but this is definitely an improvement.