nba-emu / NanoBoyAdvance

A cycle-accurate Nintendo Game Boy Advance emulator.
GNU General Public License v3.0
974 stars 56 forks source link

Crackling noise randomly occurs, even during BIOS intro #315

Closed RetroEdit closed 1 year ago

RetroEdit commented 1 year ago

I manually set interpolate_fifo = false, since I guess it was erroneously set to true. Both of the hle options are false as well.

https://www.youtube.com/watch?v=1Ut8RB_lMzg

Here's a video of starting up Shrek 2. On the first start, it had the issue, but when I reopened the game from File > Recent, it didn't happen. Overall, the crackling doesn't consistently happen when launching games, but it happens relatively often.

The specific pattern of distortions is relatively consistent when the distortion does occur.

System environment

RetroEdit commented 1 year ago

Additional note; I guess this only happens on the resampler = "cosine"? Seems like cubic might be the default, but it got reset to a non-default value in my config file. I'll use cubic, I guess.

fleroviux commented 1 year ago

An attempt to fix this was made in https://github.com/nba-emu/NanoBoyAdvance/commit/86f7649540224cafd861ff15e496aaf5187c50ee.

RetroEdit commented 1 year ago

I downloaded 49c1403 and tested this a few dozen times, and it seems to be fixed.