search

nba-emu / NanoBoyAdvance

A cycle-accurate Nintendo Game Boy Advance emulator.
GNU General Public License v3.0
972 stars 56 forks source link

(v1.8.0) Bug: Shoulder button config (L or R) is reversed #355

Closed RavenMacDaddy closed 7 months ago

RavenMacDaddy commented 7 months ago

Whether I'm controlling it with a keyboard or a controller, while playing LoZ: The Minish Cap in this case, where R = Roll - it's the button that's configured as L in the emulator that corresponds to R in the game.

fleroviux commented 7 months ago

Looks like a typo slipped through during a recent input rework - I will push out updated executables as soon as I can.

fleroviux commented 7 months ago

I have updated the binaries on the releases page. Please redownload. The issue should be fixed.

poesdelal commented 6 months ago

Still reversed after redownload (with clean config.toml)

fleroviux commented 6 months ago

Huh, it works fine for me. Are you on Linux or macOS perhaps @poesdelal? Maybe something went wrong when updating the binaries. You could also check if it's working with the latest development build.

poesdelal commented 6 months ago

Just rechecked. I'm on Win10. In dev build (master-00110ea) L and R works as intended. In release 1.8.0 (exe CRC32=D957ED0D) it's reversed. In both config.toml l=68 and r=70.

fleroviux commented 6 months ago

Weird, the CRC is correct. I have the same build running locally and the L/R buttons work as intended. I also haven't made any further adjustments to input since that singular fix.

fleroviux commented 6 months ago

Maybe try running https://github.com/shonumi/Emu-Docs/raw/master/GameBoy%20Advance/test_roms/tonc_gba_demos/key_demo.gba and check if it is really reversed and also attach a screenshot of your Input Config dialog.

poesdelal commented 6 months ago

Nano-LR