search

nba-emu / NanoBoyAdvance

A cycle-accurate Nintendo Game Boy Advance emulator.
GNU General Public License v3.0
955 stars 53 forks source link

Pokemon Radical Red crashes when Squawkabilly is sent out w/ HQ audio on #362

Closed sukerokushin closed 4 months ago

sukerokushin commented 4 months ago

Tested on Radical Red v4.0, Windows 11

Test save: go down and to the left here, start the fight with Camper Ricky—he always leads with Squawkabilly

fleroviux commented 4 months ago

It seems that this ROM hack is missing the Pokemon cry for Squawkabilly, so when trying to play its cry, the wave data will point to NULL. This rightfully triggered an assert in the code, as this should not happen normally. I have pushed a workaround that handles broken wave data by preventing the broken sound channel from playing.

If you check the latest dev build it should be working now: https://github.com/nba-emu/NanoBoyAdvance/actions/runs/8034632962