search

nbarbettini / oidc-debugger

OAuth 2.0 and OpenID Connect debugging tool
https://oidcdebugger.com
MIT License
223 stars 29 forks source link

implimentation for PKCE flow #72

Closed nickolasfisher closed 2 years ago

nickolasfisher commented 2 years ago

Fixes #39 PKCE implimentation added for S256 and plain implimentations

mraible commented 2 years ago

@nickolasfisher Can you please add "Fixes https://github.com/nbarbettini/oidc-debugger/issues/39" to the description so it closes the issue when it's merged?

nickolasfisher commented 2 years ago

@mraible added

bdemers commented 2 years ago

Note: There are a few whitespace related changes here, so adding ?w=1 to the GH URL may help with the review

nbarbettini commented 2 years ago

Thanks @nickolasfisher and @bdemers! I plan to review this PR over the weekend.

nbarbettini commented 2 years ago

@nickolasfisher This is looking good. I added some comments around UI layout and wording suggestions above. This looks almost there!

@bdemers Thanks for helping shepherd this along. Let me know if you like my wording suggestions above. If we are all in agreement about the final UI tweaks I can get this merged this week!

mraible commented 2 years ago

What's the status of this feature's implementation?

Selfishly, I'd like to record a bunch of screencasts later this month (starting April 26) using oidcdebugger.com. Currently, I have to open the Okta Admin Console and modify the OIDC app for OIDC Debugger to enable the implicit flow. It'd make the videos a lot smoother if I didn't have to do this step. You can see an example demo script here.

nbarbettini commented 2 years ago

Hey @mraible, I should be able to do a final review in the next few days. @bdemers @aaronpk are y'all good here too?

aaronpk commented 2 years ago

Looks good! Excited for this!

bdemers commented 2 years ago

➕ ❗

nbarbettini commented 2 years ago

Thanks everyone! This is live. ⚡

bdemers commented 2 years ago

Awesome!!!! Great work @nickolasfisher!