nbarbettini / oidc-debugger

OAuth 2.0 and OpenID Connect debugging tool
https://oidcdebugger.com
MIT License
223 stars 29 forks source link

Fix condition for pushing PKCE query params. #77

Closed danielshoun closed 2 years ago

danielshoun commented 2 years ago

Fixes #76

At some point during the development of the PKCE implementation, we switched from using just a radio field to a combination of a radio field and checkbox. It is no longer possible for the pkceMethod variable to have a value of 'disabled', so the query parameters were always being added to the auth request.

This PR changes the condition for adding PKCE related query parameters to instead use the usePkce checkbox value.