Nip98 enhancement - Githubissues

nbd-wtf / nostr-tools

Tools for developing Nostr clients.

The Unlicense

705 stars 197 forks source link

Nip98 enhancement #350

Closed sepehr-safari closed 9 months ago

sepehr-safari commented 9 months ago

added docs for all methods
refactored with smaller and more readable functions
added more test cases
fixed possible bugs in checking tags: urlTag?.length !== 1 && urlTag?.[1] !== url that "length !== 1" doesn't make sense.
fixed possible bugs in checking body: Boolean(body) && Object.keys(body).length > 0 that would fail in non-object inputs.

alexgleason commented 9 months ago

You may also find this useful: https://gitlab.com/soapbox-pub/ditto/-/blob/main/src/utils/nip98.ts?ref_type=heads

Some of the code in this repo is hard to trust without zod, and I end up rewriting it.

sepehr-safari commented 9 months ago

You may also find this useful: https://gitlab.com/soapbox-pub/ditto/-/blob/main/src/utils/nip98.ts?ref_type=heads

Some of the code in this repo is hard to trust without zod, and I end up rewriting it.

I could help adding Zod to nostr-tools, generally, if it was planned.