search

nbdd0121 / wsld

WSL Daemon - Stable X11 connection and time synchronisation for WSL2
Apache License 2.0
298 stars 24 forks source link

Describe how to get a fully automated setup #1

Closed pmorch closed 3 years ago

pmorch commented 3 years ago

Just updates to README.md - could be moved to another file if you'd like.

nbdd0121 commented 3 years ago

Thanks! I wouldn't put it directly under C:\Program Files though. Perhaps the instruction could be more clear that you can put it in whatever location you want, and you can use the one in %USERPROFILE%/.cargo if you want?

pmorch commented 3 years ago

I totally understand. I'll change the default paths to be the ones where it gets built.

pmorch commented 3 years ago

Actually, is like to avoid installing the rust tool chain... You write:

The binary will be installed to ~/.cargo/bin/x11-over-vsock and %USERPROFILE%.cargo\bin\x11-over-vsock.exe

Does rust under WSL2 build both of these? Then I'll just use these as the paths in the description.

pmorch commented 3 years ago

Wups, hit close by mistake...

nbdd0121 commented 3 years ago

Does rust under WSL2 build both of these? Then I'll just use these as the paths in the description.

No, actually the Windows toolchain is needed to build the Windows executable. Do you think it'll be better to suggest users to download artifacts from pipeline as the first option rather than build themselves?

pmorch commented 3 years ago

Depends on the level of paranoia.. 😂 I think most of us will just download if both options are promoted equally.

On Mon, Nov 23, 2020, 05:29 Gary Guo notifications@github.com wrote:

Does rust under WSL2 build both of these? Then I'll just use these as the paths in the description.

No, actually the Windows toolchain is needed to build the Windows executable. Do you think it'll be better to suggest users to download artifacts from pipeline as the first option rather than build themselves?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/nbdd0121/x11-over-vsock/pull/1#issuecomment-731919947, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4PDGPWAFL6MZ5PVMOO3SRHQJVANCNFSM4T45BRHQ .

pmorch commented 3 years ago

I just force-pushed pmorch:master to get a single commit containing the updated Installation chapter, incorporating the changes from issue #2. The original PR and the new changes are in this branch for reference: https://github.com/pmorch/x11-over-vsock/tree/old-installation-pr

pmorch commented 3 years ago

I have now run this setup for 13 days without incident. I'm confident that issue #2 has been resolved and that this description now leads to something that is stable.