Closed fedegiova closed 3 years ago
Hello ! Thanks a lot for your contribution. I've got some issues though, I advise you to tests your changes with this command:
# Launch this on another terminal
bash tests/launch_demo_server.sh --server_code_path ${PWD} --debug
$ /opt/cassh/src/server/server.py --config /opt/cassh/tests/cassh/cassh.conf
# When 'http://0.0.0.0:8080/' appears, start this script
bash tests/test.sh
There is a lot of failures, mainly because you unquote the password. No big deal but why did you do that ?
Also, you should add the LISTEN
parameter in the src/server/web/settings.txt.sample
file.
I will add some comments ;)
Great!! I've just seen you changes, I was trying to figure out why the tests were failing with unquote , in fact I've added it exactly because I've seen that the + sign of set-expiry was passed to unquoted to ssh-keygen which gave an error.
You figured out the solution faster than me :+1:
I'm going to remove my fork.
Regards Federico
I've close this PR, because I needed to take the ownership (I'm not that good in git to update an existing PR) Discussion here #100
Hi,
I've made a couple of patches to fix some problems that I've found during deployment.
patch n 1 is for the admin command set-expiry which doesn't unpack it arguments corrrectly patch n 2 is a small fix in the lookup of username, it might be wrong but activating an user with mixed case in their LDAP username actually lead to a mixed case username in the DB which made a successive lookup to fail patch n 3 is about adding the LISTEN parameter to the web server
regards Federico