search

nbeliy / bidsme

GNU General Public License v2.0
3 stars 0 forks source link

invalid default date format in scans.tsv #5

Closed Remi-Gau closed 4 years ago

Remi-Gau commented 4 years ago

It seems that the default data format for the scans is not the correct.

Here is the output I get from the BIDS validator.

        5: [ERR] Entries in the "acq_time" column of _scans.tsv should be expressed in the following format YYYY-MM-DDTHH:mm:ss (year, month, day, hour (24h), minute, second; this is equivalent to the RFC3339 “date-time” format.  (code: 84 - ACQTIME_FMT)
                ./sub-pilot001/ses-001/sub-pilot001_ses-001_scans.tsv
                        @ line: 2
                        Evidence: 2020-08-27T11:24:05.332500
                ./sub-pilot001/ses-001/sub-pilot001_ses-001_scans.tsv
                        @ line: 3
                        Evidence: 2020-08-27T11:33:05.332500
nbeliy commented 4 years ago

I was hoping that BIDS allows miliseconds in acq_time... Easy to fix but I will check if it doesn't broke something else

Remi-Gau commented 4 years ago

Actually I was thinking yesterday that having a bids-validator step at the end the CI on gitlab would be a good thing, no?

nbeliy commented 4 years ago

The test dataset contain MPM, it will make validator unhappy, I will need to create new test dataset (which be an improvement for sure).

Remi-Gau commented 4 years ago

just add a .bidsignore and list the stuff to ignore.

also the bids-validator has options to ignore empty-headers if you are working with dummy nifti files

nbeliy commented 4 years ago

Made a branch with fixes that fix this issue and issue #2 Can you check if it works for you?

Remi-Gau commented 4 years ago

That's fixed too. Well done. And thanks. :smile:

nbeliy commented 4 years ago

Cool, I will merge then) Thanks for spotting