Change encoding for json.loads

nbering / terraform-inventory

An Ansible dynamic inventory script to pair with nbering/terraform-provider-ansible.

MIT License

175 stars 51 forks source link

Change encoding for json.loads #20

Open emrahcetiner opened 4 years ago

emrahcetiner commented 4 years ago

Remove encoding argument from json.loads for support to pyhton 3.9 #19

obilodeau commented 3 years ago

Hey @nbering, can this patch be merged? Python 3.9 is out since early October this year and it is only a matter of time before it starts rolling out into distros.

dverbeek84 commented 3 years ago

@nbering Are you able to get this merged? I am using @obilodeau solution to work on python 3.9

obilodeau commented 3 years ago

@dverbeek84, for the record, this is not my patch. It is @emrahcetiner's.

It can be quickly applied like this:

cd YOUR_TERRAFORM.PY_LOCATION
wget https://patch-diff.githubusercontent.com/raw/nbering/terraform-inventory/pull/20.diff
patch -p1 < 20.diff
rm 20.diff

@nbering: Arch Linux is now on Python 3.9. terraform.py will now issue a fatal TypeError over there. Can you please merge this patch? Thanks!

arthurk commented 3 years ago

Any update on this? Homebrew Python is on 3.9 and this script fails

The-Loeki commented 3 years ago

Fedora 34 is Py3.9 now too so it's broken there as well without this patch