search

nberktumer / ha-bambu-lab-p1-spaghetti-detection

Bambu Lab P1 Home Assistant Spaghetti Detection Integration.
GNU General Public License v3.0
93 stars 6 forks source link

Blueprint Notification Service Input #1

Closed jeremywillans closed 4 months ago

jeremywillans commented 4 months ago

Firstly - Awesome job with this Integration, tested and it works a treat!

This PR adds a new input to the Automation blueprint allowing the definition of a custom notification service.

Providing this as a selector does not seem to exist in the blueprint framework, so its just a text input field with the default defined.

Happy for thoughts/better way of including this - I personally use different notifications services for family/admin notifications to wanted to include this flexibility.

I also reformatted the table in the README doc, this should (in theory) render correctly without the padding.

I have raised this PR against main as there is no develop branch yet 👀

nberktumer commented 4 months ago

Thank you for your contribution, but someone else has also created a PR for the same feature and I've merged it. If you can create a seperate PR for the document, it would be great.

I'll also create a development branch.