search

nbgallery / docker-images

Docker images with Jupyter and nbgallery integration
MIT License
8 stars 5 forks source link

Tags for jupyterhub versions #12

Closed kafonek closed 2 years ago

kafonek commented 4 years ago

When JupyterHub is spawning single user processes as containers (such as docker-stacks image), the downstream process needs to have jupyterhub with a matching version as the upstream Hub that did the spawning.

The jupyter/base-notebook DockerHub profile has tags for specific jupyterhub versions (e.g. hub-1.0.0). Could we please create tags for nbgallery/base-notebook that are building from jupyter/base-notebook with the appropriate Hub tags.

That will ultimately make it much easier for JupyterHub deployments to use DockerSpawner and nbgallery/base-notebook for integrating with NBGallery.

jeffyjefflabs commented 4 years ago

To clarify, are you just suggesting we tag each release of nbgallery/base-notebook with whatever version of Hub it happens to contain (which is what jupyter/base-notebook appears to do, based on the timestamps) (easy), or are you suggesting we maintain multiple builds containing our latest changes on top of multiple older upstream images (harder)? I prefer the former not only because it's easier but also because it encourages users to keep their Hub up to date.

kafonek commented 4 years ago

@jeffyjefflabs I think the former, they appear to have CI in place to set multiple tags here https://github.com/jupyter/docker-stacks/blob/master/base-notebook/hooks/apply_tags

jeffyjefflabs commented 4 years ago

I don't know if you still need this, but I added a script based on the upstream CI (which moved to here). I don't want to setup CI at the moment so it's manual for now, but results are on docker hub.

mcrutch commented 2 years ago

Can't do CI, script takes care of this, closing the ticket.