nbgrp / onelogin-saml-bundle

OneLogin SAML Symfony Bundle

BSD 3-Clause "New" or "Revised" License

43 stars 13 forks source link

Fix AuthRegistryInterface return type #16

Closed guillaume-ro-fr closed 1 year ago

guillaume-ro-fr commented 1 year ago

Like #15, but for 1.0 branch.

The Nbgrp\OneloginSamlBundle\Onelogin\AuthRegistryInterface::addService method returns AuthRegistry instead of AuthRegistryInterface: we cannot implement AuthRegistryInterface without Auth class.

codecov-commenter commented 1 year ago

Codecov Report

Merging #16 (e6f6169) into 1.0 (98f15ec) will not change coverage. The diff coverage is n/a.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98f15ec...e6f6169. Read the comment docs.

a-menshchikov commented 1 year ago

Thank you @guillaume-ro-fr .