codepathreview
commented
9 years ago Good job Nikhil. A few notes after checking out the code:
- Good to see that you completed all required stories
- Good to see that you completed many optional and bonus stories
- Overall UI look and feel can be improved
- Proper usage of sp/dp, margin and relative placement rules
- Proper use of strings.xml for localization
- Proper naming of classes, variables etc
- Good to see that you are using viewholder pattern for better performance of grid view
- Consider adding error handling
One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to complete the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
My app is complete, please review. /cc @codepathreview @codepath