nbia-astro / skeletor

Parallel PIC code written in Python and based on the skeleton codes provided by PICKSC
GNU General Public License v3.0
1 stars 0 forks source link

Improve Makefile/setup.py #111

Open tobson opened 7 years ago

tobson commented 7 years ago
  1. The code should compile without OpenMP. Right now, a non-OpenMP compiler (such as the one that comes with OS X) either complains about the flag -fopenmp or -- if that is removed -- throws strange errors like this:

    skeletor/cython/push_and_deposit.c:1928:8: error: 'inline' can only appear on
      functions
    static CYTHON_INLINE int (*__pyx_f_8skeletor_6cython_17particle_boundary...
       ^
    skeletor/cython/push_and_deposit.c:396:27: note: expanded from macro
      'CYTHON_INLINE'
    #define CYTHON_INLINE __inline__ __attribute__ ((__unused__))
  2. Running make clean shouldn't "cythonize" all *.pyx files as it sometimes does.

  3. It would be nice if certain options could be passed on the command line when building the code. Something like

    ./configure --with-openmp

    Let's not use autotools though...