particles['x'] and ['y'] now always in grid units

nbia-astro / skeletor

Parallel PIC code written in Python and based on the skeleton codes provided by PICKSC

GNU General Public License v3.0

1 stars 0 forks source link

particles['x'] and ['y'] now always in grid units #121

Closed tobson closed 7 years ago

tobson commented 7 years ago

I think it's best (least confusing) for the coordinates in the particle array not to measured in different units in different parts of the code.

tobson commented 7 years ago

@tberlok Let's do a rebase and merge if you agree with this change.

tberlok commented 7 years ago

I am going to bed, feel free to rebase and merge after adding the changes to the DensityPertubation class.

tobson commented 7 years ago

It looks like you'll now need to update your review and approve of the changes before this can be merged. I can also dismiss your review, but that seems like poor form...